@link and @see resolve C.m as a class property reference #43625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is pretty good, the scribbles are actually cleanup from last PR, although they break some tests.
Turns out that you can't reuse check* functions if you want to retrieve all meanings of a reference.
typescript-bot
added
Author: Team
For Milestone Bug
|
@mjbvz You were interested in this. |
tests/baselines/reference/findAllReferencesLinkTag1.baseline.jsonc
Outdated
Show resolved
Hide resolved
andrewbranch
requested changes
Apr 12, 2021
| // } | ||
| // | ||
| // interface I { | ||
| // [|a|]/*FIND ALL REFS*/() |
There was a problem hiding this comment.
This one, and the one on b, also have no results apart from themselves. Couldn’t tell for sure whether that was expected.
There was a problem hiding this comment.
I was just lazy and omitted the tests that should start passing in this PR. I added some references that will pass with this PR.
andrewbranch
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not match real TS references, but is extremely common. It also matches the lookup that will have to happen for
C#m, but doesn't require any new parsing.Fixes #43383 but not #43594 or #43595