Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass throwIfNoEntry to fs.statSync #41604

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Nov 20, 2020

Future versions of node will be able to return undefined, rather than allocating and throwing an exception, when a file is not found.

See nodejs/node#33716

Future versions of node will be able to return undefined, rather than
allocating and throwing an exception, when a file is not found.

See nodejs/node#33716
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 20, 2020
@amcasey amcasey merged commit 669305b into microsoft:master Nov 23, 2020
@amcasey amcasey deleted the ThrowIfNoEntry branch November 23, 2020 20:43
DanielRosenwasser pushed a commit that referenced this pull request Jun 14, 2021
Future versions of node will be able to return undefined, rather than
allocating and throwing an exception, when a file is not found.

See nodejs/node#33716
DanielRosenwasser pushed a commit that referenced this pull request Jun 14, 2021
Future versions of node will be able to return undefined, rather than
allocating and throwing an exception, when a file is not found.

See nodejs/node#33716
DanielRosenwasser pushed a commit that referenced this pull request Jun 14, 2021
Future versions of node will be able to return undefined, rather than
allocating and throwing an exception, when a file is not found.

See nodejs/node#33716
DanielRosenwasser added a commit that referenced this pull request Jun 15, 2021
Future versions of node will be able to return undefined, rather than
allocating and throwing an exception, when a file is not found.

See nodejs/node#33716

Co-authored-by: Andrew Casey <[email protected]>
DanielRosenwasser added a commit that referenced this pull request Jun 15, 2021
Future versions of node will be able to return undefined, rather than
allocating and throwing an exception, when a file is not found.

See nodejs/node#33716

Co-authored-by: Andrew Casey <[email protected]>
DanielRosenwasser added a commit that referenced this pull request Jun 15, 2021
Future versions of node will be able to return undefined, rather than
allocating and throwing an exception, when a file is not found.

See nodejs/node#33716

Co-authored-by: Andrew Casey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants