🤖 Pick PR #40880 (Handle noEmit and noEmitOnError wit...) into release-4.0 #41107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Component commits: ca35546 Add test that fails c7b5005 Handle noEmit on semantic builder's emit as well 6a05abd Add test for tsbuildinfo text verification 8bae521 Fix noEmit handling for tsbuildinfo emit with SemanticDiagnosticBuilder 0fd4a08 Add test for noEmitOnError with SemanticDiagnosticsBuilder 4fa1d78 Fix tsbuildinfo emit with SemanticDiagnosticsBuilder on noEmitOnError a3968e7 Update src/compiler/builder.ts Co-authored-by: Nathan Shively-Sanders <[email protected]> 174b00a Update src/compiler/builder.ts
typescript-bot
added
the
For Uncommitted Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-pick was triggered by a request on #40880
Please review the diff and merge if no changes are unexpected.
You can view the cherry-pick log here.
cc @DanielRosenwasser