Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust typeof import name lookup to better match type query lookup #40985

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Adjust typeof import name lookup to better match type query lookup #40985

merged 2 commits into from
Oct 30, 2020

Conversation

weswigham
Copy link
Member

Fixes #39797

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Oct 7, 2020
sandersn
sandersn requested changes Oct 7, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions about the intent, and the comment to describe it.

src/compiler/checker.ts Show resolved Hide resolved
src/compiler/checker.ts Show resolved Hide resolved
@weswigham
Copy link
Member Author

@sandersn ?

@weswigham weswigham merged commit e044b56 into microsoft:master Oct 30, 2020
@weswigham weswigham deleted the static-decl-ref branch October 30, 2020 18:13
@andrewbranch andrewbranch mentioned this pull request Sep 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

Assignees

@weswigham weswigham

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TS infer type for class static field with error
3 participants
@weswigham @sandersn @typescript-bot