-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always create optional properties when spreading objects conditionally #40778
Always create optional properties when spreading objects conditionally #40778
Conversation
@typescript-bot pack this |
Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 4156662. You can monitor the build here. |
Heya @weswigham, I've started to run the tarball bundle task on this PR at 4156662. You can monitor the build here. |
Heya @weswigham, I've started to run the perf test suite on this PR at 4156662. You can monitor the build here. Update: The results are in! |
Heya @weswigham, I've started to run the extended test suite on this PR at 4156662. You can monitor the build here. |
Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 4156662. You can monitor the build here. |
Hey @weswigham, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build. |
@weswigham Here they are:Comparison Report - master..40778
System
Hosts
Scenarios
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
Looks good in the project that inspired the bug. |
@typescript-bot pack this |
Heya @ahejlsberg, I've started to run the tarball bundle task on this PR at 4156662. You can monitor the build here. |
Hey @ahejlsberg, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build. |
Do we want this in 4.1 or in 4.2? |
I vote 4.1. |
FWIW, the design notes suggested we settled on 4.2. |
Nobody seemed to object to moving this to 4.1 in today's standup, so I'm assuming I should do so. |
Fixes #40754