Skip to content

Add full stops in diagnostic messages #40165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2020
Merged

Add full stops in diagnostic messages #40165

merged 3 commits into from
Sep 8, 2020

Conversation

cherryblossom000
Copy link
Contributor

Fixes #37753

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Aug 21, 2020
@ghost
Copy link

ghost commented Aug 21, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

DanielRosenwasser
DanielRosenwasser reviewed Aug 21, 2020
View reviewed changes
tests/baselines/reference/jsxFactoryAndFragment.errors.txt Outdated
!!! error TS17016: The 'jsxFragmentFactory' compiler option must be provided to use JSX fragments with the 'jsxFactory' compiler option.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a diff here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think VSCode added a newline to the end of the file and trimmed the whitespace when I was resolving merge conflicts.

sandersn
sandersn approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew, there are 14 of them! I was afraid we had forgotten the period on basically every message. =)

@sandersn sandersn merged commit 2ef393b into microsoft:master Sep 8, 2020
@cherryblossom000 cherryblossom000 deleted the typo branch September 8, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser left review comments

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some diagnostic messages missing full stops/periods
4 participants
@cherryblossom000 @sandersn @DanielRosenwasser @typescript-bot