Add '(approximate)' to the beginning of quick info requests in PartialSemantic mode

[DanielRosenwasser]

[DanielRosenwasser]

@typescript-bot cherry-pick this to release-4.0

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.0 on this PR at 54f988c. You can monitor the build here.

[typescript-bot]

Hey @DanielRosenwasser, I've opened #40062 for you.

[ahejlsberg]

Not sure I like the line break. I'd just have it prefix the quick info on the same line. Also, maybe a better prefix is "(approximation)". Otherwise, looks good.

[DanielRosenwasser]

Well, I did try both. Here's what same line looked like.

[ahejlsberg]

I like the single line better!

[DanielRosenwasser]

It's sort of a shame that "partial mode" is really something up to interpretation by each editor. Otherwise, I'd just say we should display "loading" which works kind of nicely when the semantic server comes back with a response.

[DanielRosenwasser]

This is what it'll look like

[DanielRosenwasser]

@typescript-bot cherry-pick this to release-4.0 and LKG

[typescript-bot]

Heya @DanielRosenwasser, I'm starting to run the task to cherry-pick this into release-4.0 on this PR at 05f1301. Hold tight - I'll update this comment with the log link once the build has been queued.

[sheetalkamat]

Should we do this for completion details too?

[mjbvz]

Sorry @DanielRosenwasser, just seeing this now. I like the single line version.

A few questions:

• I think we may need to add some use facing explanation around approximation. Such as in the hover contents, have a string that says something like, this result is an best effort approximation because the project is still loading (with better phrasing)

• I believe VS Code could have determined this itself? Or are there cases where we can be sure the the partial server is returning the full result? If TS Server does need to tell us which results are approximate, would a new flag on the response object be better so that editors can determine how to display it?

[DanielRosenwasser]

I think ideally the editor would display this itself (and is capable of doing so); if we think we can get something to do this in the August release of VS Code, then I would say we should back out the change now.