Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin dependencies in release branch #39989

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Aug 11, 2020

With this change, you can build the branch using npm ci && npm run build.

With this change, you can build the branch using `npm ci && npm run
build`.
@amcasey amcasey requested a review from weswigham August 11, 2020 01:04
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 11, 2020
@amcasey
Copy link
Member Author

amcasey commented Aug 11, 2020

I'd like to do this for every release branch, going forward. Re-adding people to the PR, since they probably care more now that it's not about 3.3. 😄

@weswigham
Copy link
Member

weswigham commented Aug 11, 2020

Should we also edit https://github.com/microsoft/TypeScript/blob/master/.github/workflows/new-release-branch.yaml (on master) to do this for new branches automatically, while we're at it?

@amcasey
Copy link
Member Author

amcasey commented Aug 11, 2020

@weswigham What is it?

@weswigham
Copy link
Member

It's a bot powered workflow for setting up new release branches~

@amcasey
Copy link
Member Author

amcasey commented Aug 11, 2020

@weswigham TBH, I prefer @andrewbranch's suggestion that we move to an automatically updated, checked in package-lock.json in master. However, if we decide not to pursue that option, I agree that automating this process would be worthwhile.

@amcasey amcasey requested a review from sandersn August 11, 2020 18:42
@amcasey
Copy link
Member Author

amcasey commented Aug 12, 2020

I want to merge this regardless of what we decide to do in master. Objections?

@sandersn
Copy link
Member

👍 for this while we decide on a general solution.

@amcasey amcasey merged commit edaa8aa into microsoft:release-4.0 Aug 13, 2020
@amcasey amcasey deleted the pinned-release-4.0 branch August 13, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants