Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support variadic tuple inference from trailing optional to non-optional #39614

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Support variadic tuple inference from trailing optional to non-optional #39614

merged 2 commits into from
Jul 16, 2020

Conversation

ahejlsberg
Copy link
Member

Fixes #39607.

@DanielRosenwasser
Copy link
Member

Is it worth having an ElementFlags.Individual to describe something that's just not a rest element?

@ahejlsberg ahejlsberg merged commit db79030 into master Jul 16, 2020
@ahejlsberg ahejlsberg deleted the variadicInferenceOptionalToNonOptional branch July 16, 2020 00:46
@ahejlsberg
Copy link
Member Author

Is it worth having an ElementFlags.Individual to describe something that's just not a rest element?

I was close to adding an ElementFlags.Fixed for the ElementFlags.Required | ElementFlags.Optional combination, but not sure it adds a lot of clarity.

@ahejlsberg ahejlsberg mentioned this pull request Jul 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No variadic tuple inference from trailing optional to non-optional
2 participants
@ahejlsberg @DanielRosenwasser