Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extensions to bin scripts. #39380

Closed
wants to merge 2 commits into from
Closed

Add extensions to bin scripts. #39380

wants to merge 2 commits into from

Conversation

sosoba
Copy link

@sosoba sosoba commented Jul 2, 2020

Adption to changes in Node.
See nodejs/node#31415

Fixes #

Adption to changes in Node.
See nodejs/node#31415
@ghost
Copy link

ghost commented Jul 2, 2020

CLA assistant check
All CLA requirements met.

@orta
Copy link
Contributor

orta commented Jul 6, 2020

I'm a bit wary that the bin/tsc → bin/tsc.js feels likely to break something somewhere (given the amount of platforms / tools which embed TS.) Perhaps a safe solution is to add new files for the .js(each of these files is only 2 LOC long anyway)?

@sosoba
Copy link
Author

sosoba commented Jul 8, 2020

Perhaps a safe solution is to add new files for the .js

It's a good point. Can i change PR and add "twins"?

@RyanCavanaugh
Copy link
Member

Appears to be a fix for #39381

Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of how this could break something, so if another TS member feels good with it then we should be good to merge

@weswigham
Copy link
Member

We... don't set type: module in our package.json - #39381 is totally indicative of an error in the implementation of the experimental flag in node itself.

@RyanCavanaugh
Copy link
Member

@weswigham effectively OP is experiencing this issue? nodejs/node#33226

I don't think we should merge anything with nonzero risk in order to enable experimental node stuff

@weswigham
Copy link
Member

Yep, that looks to be a report of the same thing.

@orta
Copy link
Contributor

orta commented Jul 10, 2020

This makes sense, we should probably close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants