Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always error on property override accessor #37894

Merged
merged 10 commits into from
May 26, 2020
Merged

Always error on property override accessor #37894

merged 10 commits into from
May 26, 2020

Commits on Apr 9, 2020

  1. Always error when property overrides accessor or vice versa 

    Previously this was only an error when useDefineForClassFields: true,
but now it's an error for all code. This is a rare mistake to make, and
usually only occurs in code written before `readonly` was available.

Codefix to come in subsequent commits.
    @sandersn
    sandersn committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    3ffe253 View commit details
    Browse the repository at this point in the history

  2. add fourslash tests for codefix

    @sandersn
    sandersn committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    71b7695 View commit details
    Browse the repository at this point in the history

  3. Codefix invokes generate get-set accessor refactor 

    1. Add add-all test
2. Add codefix that delegates to get-set accessor refactor.

Needs massive amounts of cleanup and deduplication.
    @sandersn
    sandersn committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    e287c83 View commit details
    Browse the repository at this point in the history

  4. refactoring done except for deduping

    @sandersn
    sandersn committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    3030cd8 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2020

  1. move into new, centrally (?) located file

    @sandersn
    sandersn committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    6eacc9c View commit details
    Browse the repository at this point in the history

  2. Reorder tsconfig and move one more function

    @sandersn
    sandersn committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    3428e27 View commit details
    Browse the repository at this point in the history

  3. Minor cleanup 

    1. Fix lint.
2. Make code easier to read.
3. Turns some asserts into bails instead.
    @sandersn
    sandersn committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    4d541d2 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2020

  1. Merge branch 'master' into always-error-on-property-override-accessor

    @sandersn
    sandersn committed May 21, 2020
    Configuration menu
    Copy the full SHA
    802e87b View commit details
    Browse the repository at this point in the history

Commits on May 22, 2020

  1. Merge branch 'master' into always-error-on-property-override-accessor

    @sandersn
    sandersn committed May 22, 2020
    Configuration menu
    Copy the full SHA
    82d9576 View commit details
    Browse the repository at this point in the history

  2. Fix multi-file usage 

    1. Follow aliases with getSupers.
2. Make fix in file with superclass, not with the error.
    @sandersn
    sandersn committed May 22, 2020
    Configuration menu
    Copy the full SHA
    e466bb9 View commit details
    Browse the repository at this point in the history