Generic functions are never context sensitive #37811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@typescript-bot test this |
Collaborator
|
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 2cb8b25. You can monitor the build here. |
Collaborator
|
Heya @ahejlsberg, I've started to run the extended test suite on this PR at 2cb8b25. You can monitor the build here. |
Collaborator
|
Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at 2cb8b25. You can monitor the build here. |
Collaborator
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
Member
Author
|
@RyanCavanaugh All tests are clean. Want to take a quick look? |
weswigham
approved these changes
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue introduced by #36476 where a generic function would be considered context sensitive even though it never should be (and never was before that PR).
Fixes #37110.