Skip to content

feat(37782): 'declare method' quick fix for adding a private method #37806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 6, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #37782

@a-tarasyuk a-tarasyuk force-pushed the feat/37782 branch 6 times, most recently from c3ac1bc to ca56d42 Compare April 6, 2020 13:52
@sandersn sandersn added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 15, 2020
@amcasey
Copy link
Member

amcasey commented Apr 17, 2020

@a-tarasyuk Thanks for tidying up the code, but I have to admit I'm having trouble figuring out what actually changed. It seems like it was already possible to add a method, public property, or private property - just not a private property? Was anything special required to light up that last scenario?

Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things seem generally correct, I'm just having trouble identifying the new code.

@a-tarasyuk a-tarasyuk requested a review from amcasey April 17, 2020 06:55
@sandersn sandersn merged commit 683b3ec into microsoft:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

'declare method' quick fix for adding a private method
4 participants