Extra check in assignment of intersections with generic constituents

[ahejlsberg]

This PR expands the additional check in #37195 to also cover intersections with generic constituents.

Fixes #36637.

[ahejlsberg]

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt

[typescript-bot]

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at f504c36. You can monitor the build here.

[typescript-bot]

Heya @ahejlsberg, I've started to run the extended test suite on this PR at f504c36. You can monitor the build here.

[typescript-bot]

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at f504c36. You can monitor the build here.

[weswigham]

It's unfortunate that weakType.errors.txt has an extra line of elaboration we previously got rid of, but otherwise this looks pretty good. The comment in isRelatedTo is appreciated.

[typescript-bot]

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

[ahejlsberg]

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt

[typescript-bot]

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at b1fe1b2. You can monitor the build here.

[typescript-bot]

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at b1fe1b2. You can monitor the build here.

[typescript-bot]

Heya @ahejlsberg, I've started to run the extended test suite on this PR at b1fe1b2. You can monitor the build here.

[ahejlsberg]

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt

[typescript-bot]

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 0d99510. You can monitor the build here.

[typescript-bot]

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at 0d99510. You can monitor the build here.

[typescript-bot]

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 0d99510. You can monitor the build here.

[ahejlsberg]

@typescript-bot run dt
@typescript-bot test this
@typescript-bot user test this

[typescript-bot]

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 5a9ddd7. You can monitor the build here.

[typescript-bot]

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at 5a9ddd7. You can monitor the build here.

[typescript-bot]

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 5a9ddd7. You can monitor the build here.

[ahejlsberg]

@typescript-bot run dt
@typescript-bot user test this

[typescript-bot]

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 2beca5c. You can monitor the build here.

[typescript-bot]

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at 2beca5c. You can monitor the build here.

[ahejlsberg]

@weswigham @pirix-gh I'm seeing the following failure in ts-toolbelt with this PR.

https://github.com/typescript-bot/TypeScript/pull/7/files#diff-1f3859ff65d5bfe2538629eb58913345R3

It is the one gating issue for merging the PR. Any ideas?

[ahejlsberg]

@typescript-bot pack this

[typescript-bot]

Heya @ahejlsberg, I've started to run the tarball bundle task on this PR at 2beca5c. You can monitor the build here.

[typescript-bot]

Hey @ahejlsberg, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/70440/artifacts?artifactName=tgz&fileId=786456A3F5C139144205509C45D5235CBFEE4324AC5DCAA0354DFFCD504CA17102&fileName=/typescript-3.9.0-insiders.20200404.tgz"
    }
}

and then running npm install.

[millsp]

The fix is out! I mistakenly swapped the lhs & rhs on the terminating condition of Repeat. I am glad to see how many little mistakes have been caught on this 3.9 release 🎉 Thanks!

[ahejlsberg]

@typescript-bot run dt
@typescript-bot user test this

[typescript-bot]

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at 2beca5c. You can monitor the build here.

[typescript-bot]

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 2beca5c. You can monitor the build here.

[ahejlsberg]

RWC and Community Code test suites are clean, and I have a PR up to fix new error in vuelidate on DefinitelyTyped.

@RyanCavanaugh @DanielRosenwasser I think we should move this PR back into the 3.9 release. We have already merged #37195 and this PR just finishes the job. It fixes #36637 and uncovered legit issues in ts-toolbelt and vuelidate, but otherwise appears to have no downside.