Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle auto import scenarios when using project references #37482

Merged
merged 3 commits into from
Mar 19, 2020

Conversation

sheetalkamat
Copy link
Member

When importing file that is source file of .d.ts file from referenced project, add its .d.ts file as possible filename as well. This change also needed to use the fileExists function from program (which pretends that d.ts file for referenced project exists even if it doesn't) to ensure that we can use the symlink in that scenario.
Fixes #34677

… file is source of project reference redirect

Fixes the auto import suggestion when project is built
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This was really annoying when working in a lerna monorepo with project references recently. Checked this PR out and confirmed it’s a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto import paths dont handle source of projectReferenceRedirect in editor
3 participants