🤖 User test baselines have changed for refs/heads/master #37203
Conversation
typescript-bot
force-pushed
the
user-update-Microsoft-20200304-refs/heads/master
branch
3 times, most recently
from
312d21a
to
354aecf
Compare
There was a problem hiding this comment.
Looks like 3 new errors today. @weswigham can you see whether the arity change is too breaky to keep? Webpack only had two breaks, which is a positive sign.
I'll figure out where the other two, in fp-ts and jimp, came from.
| @@ -20,6 +20,13 @@ node_modules/acorn/bin/_acorn.js(63,23): error TS2769: No overload matches this | |||
| node_modules/acorn/bin/run_test262.js(3,21): error TS2307: Cannot find module 'test262-parser-runner'. | |||
| node_modules/acorn/dist/acorn.es.js(36,1): error TS2322: Type 'null' is not assignable to type 'string'. | |||
| node_modules/acorn/dist/acorn.es.js(36,32): error TS2322: Type 'null' is not assignable to type 'string'. | |||
| node_modules/acorn/dist/acorn.es.js(150,8): error TS2554: Expected 2 arguments, but got 1. | |||
There was a problem hiding this comment.
there are a lot of these, probably from #37173
There was a problem hiding this comment.
Maybe; but that change only updates isOptionalParameter to use the stronger arity getMinArgumentCount call, and that, in turn, is only used by API functions and node serialization. It would only be if somewhere we were looking at signature.minArgumentCount directly that it could change (which is only used by signature cloning, isPotentiallyUncalledDecorator (which should probably use a call to getMinArgumentCount tbh), and getMinArgumentCount, so that can't be the case).
| @@ -0,0 +1,11 @@ | |||
| Exit Code: 1 | |||
| Standard output: | |||
| test/property-test/Option.ts(25,3): error TS2322: Type 'Arbitrary<None | Some<unknown> | Some<A>>' is not assignable to type 'Arbitrary<Option<A>>'. | |||
There was a problem hiding this comment.
I can't think of an obvious candidate for this one, tbh.
| @@ -0,0 +1,8 @@ | |||
| Exit Code: 1 | |||
| Standard output: | |||
| node_modules/@jimp/core/types/utils.d.ts(16,3): error TS2536: Type '"class"' cannot be used to index type 'T'. | |||
There was a problem hiding this comment.
This is from the "make T extends any -> T extends unknown" change. jimp was making use of a T extends any constraint to silence a very blatant error. The types can be rewritten to prevent the error with an Extract conditional usage.
typescript-bot
force-pushed
the
user-update-Microsoft-20200304-refs/heads/master
branch
3 times, most recently
from
abfe14f
to
179ca18
Compare
typescript-bot
force-pushed
the
user-update-Microsoft-20200304-refs/heads/master
branch
from
179ca18
to
06467e4
Compare
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript