Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce intersections by discriminants #36696

Merged
merged 35 commits into from
Feb 29, 2020
Merged

Reduce intersections by discriminants #36696

merged 35 commits into from
Feb 29, 2020
+1,231 −189

Commits on Feb 8, 2020

  1. Treat never-like intersections as never

    @ahejlsberg
    ahejlsberg committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    ace0904 View commit details
    Browse the repository at this point in the history

  2. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    eaf872c View commit details
    Browse the repository at this point in the history

  3. Fix compiler issues revealed by increased intersection correctness

    @ahejlsberg
    ahejlsberg committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    94353d2 View commit details
    Browse the repository at this point in the history

  4. Delete fourslash tests that are no longer applicable

    @ahejlsberg
    ahejlsberg committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    346ec30 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2020

  1. Include isNeverLikeIntersection check in getNormalizedType

    @ahejlsberg
    ahejlsberg committed Feb 9, 2020
    Configuration menu
    Copy the full SHA
    acd3fec View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2020

  1. Erase never-like types in several more places

    @ahejlsberg
    ahejlsberg committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    7ae4a21 View commit details
    Browse the repository at this point in the history

  2. Check that base types are not never-like

    @ahejlsberg
    ahejlsberg committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    3a1ba48 View commit details
    Browse the repository at this point in the history

  3. Add comments

    @ahejlsberg
    ahejlsberg committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    e1434a5 View commit details
    Browse the repository at this point in the history

  4. Revert isNeverLikeType check in getIndexType (keyof shouldn't resolve… 

    … member types)
    @ahejlsberg
    ahejlsberg committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    37c6280 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. Introduce getReducedType for union and intersection types

    @ahejlsberg
    ahejlsberg committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    dba1043 View commit details
    Browse the repository at this point in the history

  2. Don't reduce in getApparentType

    @ahejlsberg
    ahejlsberg committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    f170191 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2020

  1. Avoid relationship check in resolveMappedTypeMembers

    @ahejlsberg
    ahejlsberg committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    6b2f3a2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into neverLikeIntersections 

    # Conflicts:
#	src/compiler/checker.ts
    @ahejlsberg
    ahejlsberg committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    aeab6af View commit details
    Browse the repository at this point in the history

  3. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    4f67910 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2020

  1. Don't call getReducedType in getIndexType

    @ahejlsberg
    ahejlsberg committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    49302f2 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2020

  1. Ensure reduced and unreduced forms of a type can compare identical

    @ahejlsberg
    ahejlsberg committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    aa8d227 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2020

  1. Reduce types before converting them to string representation

    @ahejlsberg
    ahejlsberg committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    8907e92 View commit details
    Browse the repository at this point in the history

  2. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    04facee View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2020

  1. Reduce intersections before obtaining keyof X

    @ahejlsberg
    ahejlsberg committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    88be5ea View commit details
    Browse the repository at this point in the history

  2. Add tests

    @ahejlsberg
    ahejlsberg committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    fbf13dc View commit details
    Browse the repository at this point in the history

  3. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    85447a5 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2020

  1. Fix comment in tests

    @ahejlsberg
    ahejlsberg committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    7741085 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2020

  1. Don't infer from empty intersection types

    @ahejlsberg
    ahejlsberg committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    d2b3807 View commit details
    Browse the repository at this point in the history

  2. Add tests

    @ahejlsberg
    ahejlsberg committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    6590e20 View commit details
    Browse the repository at this point in the history

  3. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    40340ae View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. Defer instantiation of mapped type property types

    @ahejlsberg
    ahejlsberg committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    c4c1418 View commit details
    Browse the repository at this point in the history

  2. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    8eb08e8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into neverLikeIntersections 

    # Conflicts:
#	src/compiler/checker.ts
    @ahejlsberg
    ahejlsberg committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    874938c View commit details
    Browse the repository at this point in the history

  4. Include more precise type in diagnostic

    @ahejlsberg
    ahejlsberg committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    ede9d01 View commit details
    Browse the repository at this point in the history

  5. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    42022f3 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. Minor optimization

    @ahejlsberg
    ahejlsberg committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    e24b250 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into neverLikeIntersections 

    # Conflicts:
#	src/compiler/types.ts
    @ahejlsberg
    ahejlsberg committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    12f6224 View commit details
    Browse the repository at this point in the history

  3. Improve error message

    @ahejlsberg
    ahejlsberg committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    a015ab9 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2020

  1. Merge branch 'master' into neverLikeIntersections 

    # Conflicts:
#	src/compiler/checker.ts
    @ahejlsberg
    ahejlsberg committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    95ecb7b View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. Optional properties in intersections are never discriminants

    @ahejlsberg
    ahejlsberg committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    b99b9b2 View commit details
    Browse the repository at this point in the history