-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw syntax error for }
and >
in JSX text
#36636
Conversation
This is great, I don't have any code recommendations (given the simplicity of the implementation) and the tests look good. I went to check babels implementation details only to find my way back to the linked issue. My only question is do you want to add a codefix for these too? |
Yeah sorry, I raised issues in acorn, babel and typescript together (and PR'd it into babel) 😄
Sure, I'd love to! |
Yes, it is the right place (: |
Took me a minute to figure everything out, but I got there in the end. |
This looks perfect, thanks @bradzacher 👍 |
Nice one, immediately caught an error in a DT test case 👌 |
Fixes #36341
This is my first PR for typescript, so please LMK if there's a better way to do this.