Add flag to omit default case in getSwitchClauseTypeOfWitnesses #33574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-williams
force-pushed
the
add-flag-to-getSwitchClauseTypeOfWitnesses
branch
2 times, most recently
from
32f5613 to
df61cca
Compare
|
<FIXED> |
…itchClauseTypeOfWitnesses
weswigham
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of #32695 the code that was ensuring that the cast was safe is now checked by the caller of
isExhaustiveSwitchStatement. Rather than worrying about whether the caller has the necessary invariants in place to make the cast safe, just handle it directly.