Skip to content

Conversation

@typescript-bot
Copy link
Collaborator

Please review the diff and merge if no changes are unexpected.
You can view the build log here.

cc @weswigham @sandersn @RyanCavanaugh

@weswigham
Copy link
Member

cc @rbuckton you look over these changes form the generator types PR yet?

@rbuckton
Copy link
Contributor

rbuckton commented Jul 5, 2019

I reviewed them following an on-demand run, but I'm not certain how to proceed. Do I accept these changes as is, or do I need to submit issues against the user test repositories for errors? The majority of changes are due to outdated NodeJS definitions.

@weswigham
Copy link
Member

It's up to us - if updating these projects for their maintainers is too cumbersome, we can accept the baseline (which just means merging this PR), but that does lower how clean the baselines are and how easy it is to identify future change. Plus, at least for the rush-build projects the error blocks the build, which really hurts the test value :P

@weswigham weswigham closed this Jul 10, 2019
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants