Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report multiple overload errors #32092

Merged
merged 35 commits into from
Jul 8, 2019
Merged

Report multiple overload errors #32092

merged 35 commits into from
Jul 8, 2019

Commits on Jun 18, 2019

  1. Initial attempt. Totally doesn't work.

    @sandersn
    sandersn committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    c65d9f2 View commit details
    Browse the repository at this point in the history

  2. Working, just not the way I would like 

    There are still separate errors instead of one + related spans for each
sub-error.
    @sandersn
    sandersn committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    beddf9c View commit details
    Browse the repository at this point in the history

  3. Notes on how to return errors from checkTypeRelatedTo

    @sandersn
    sandersn committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    caff266 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2019

  1. Merge branch 'master' into report-multiple-overload-errors

    @sandersn
    sandersn committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    e5fd876 View commit details
    Browse the repository at this point in the history

  2. Re-add multiple errors 

    In the worst possible way. Now it's sort of ready for creating a
DiagnosticMessageTree.
    @sandersn
    sandersn committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    1f6ef05 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2019

  1. Use related spans to form a tree of errors. 

    Formatting is wrong, and I might want to format it as non-related spans,
but the structure is exactly a tree.
    @sandersn
    sandersn committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    afecb87 View commit details
    Browse the repository at this point in the history

  2. Share code a bit better

    @sandersn
    sandersn committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    ef0a875 View commit details
    Browse the repository at this point in the history

  3. Retain related info for 1-overloads

    @sandersn
    sandersn committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    b85796c View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2019

  1. Improve error message and update baselines

    @sandersn
    sandersn committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    720ad5b View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2019

  1. Use existing reporting mechanism

    @sandersn
    sandersn committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    ecfa902 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2019

  1. Update baselines, except JSX 

    JSX is still broken
    @sandersn
    sandersn committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    f20f700 View commit details
    Browse the repository at this point in the history

  2. Don't double-check JSX calls 

    The JSX code path stands on its own
    @sandersn
    sandersn committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    66244f7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into report-multiple-overload-errors

    @sandersn
    sandersn committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    67b8ca7 View commit details
    Browse the repository at this point in the history

  4. Fix lint and remove done TODOs

    @sandersn
    sandersn committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    b58932e View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. Improve error messages and related spans

    @sandersn
    sandersn committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    68968fd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into report-multiple-overload-errors

    @sandersn
    sandersn committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    c0ff286 View commit details
    Browse the repository at this point in the history

  3. Do not report multiple diagnostics per signature. 

    If there are multiple diagnostics per signature, choose the signature
with the fewer diagnostics to report. If there are more than one with
the minimum, choose the latest in the overload set.
    @sandersn
    sandersn committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    0436cfc View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2019

  1. Fix lint, remove overloads

    @sandersn
    sandersn committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    35dda10 View commit details
    Browse the repository at this point in the history

  2. Switch DiagnosticMessageChain to be a tree

    @sandersn
    sandersn committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    ba9d8e2 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2019

  1. Convert related spans to message chains

    @sandersn
    sandersn committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    47bbc95 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into report-multiple-overload-errors

    @sandersn
    sandersn committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    c48018f View commit details
    Browse the repository at this point in the history

  3. Fix lint

    @sandersn
    sandersn committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    9778474 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into report-multiple-overload-errors

    @sandersn
    sandersn committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    71276a2 View commit details
    Browse the repository at this point in the history

  5. Update baselines with new error numbers

    @sandersn
    sandersn committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    34c4047 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2019

  1. Merge branch 'master' into report-multiple-overload-errors

    @sandersn
    sandersn committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    cce2b93 View commit details
    Browse the repository at this point in the history

  2. Update baselines

    @sandersn
    sandersn committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    1906142 View commit details
    Browse the repository at this point in the history

  3. Address PR comments

    @sandersn
    sandersn committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    f139455 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2019

  1. Update baselines

    @sandersn
    sandersn committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    de52797 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2019

  1. Merge branch 'master' into report-multiple-overload-errors

    @sandersn
    sandersn committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    e62d84c View commit details
    Browse the repository at this point in the history

  2. Update baselines

    @sandersn
    sandersn committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    d92e8ea View commit details
    Browse the repository at this point in the history

  3. Remove TODO

    @sandersn
    sandersn committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    722917f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into report-multiple-overload-errors

    @sandersn
    sandersn committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    19b593e View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2019

  1. Merge branch 'master' into report-multiple-overload-errors

    @sandersn
    sandersn committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    834a476 View commit details
    Browse the repository at this point in the history

  2. Update baselines

    @sandersn
    sandersn committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    2233eba View commit details
    Browse the repository at this point in the history

  3. Update more baselines (?)

    @sandersn
    sandersn committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    05a4e8f View commit details
    Browse the repository at this point in the history