🤖 User test baselines have changed #30832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
force-pushed
the
user-update-Microsoft-20190302
branch
from
6c3c025 to
923c381
Compare
sandersn
approved these changes
Apr 9, 2019
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
All the changes are results of DOM updates.
I fixed the new error in webpack, but it'll be a few days before it ships. The other errors are OK to accept.
| Exit Code: 1 | ||
| Standard output: | ||
| ../../../../../built/local/lib.dom.d.ts(17566,19): error TS2451: Cannot redeclare block-scoped variable 'WebAssembly'. | ||
| declarations.d.ts(258,15): error TS2451: Cannot redeclare block-scoped variable 'WebAssembly'. |
| lib/Page.js(284,15): error TS2503: Cannot find namespace 'Protocol'. | ||
| lib/Page.js(369,20): error TS2503: Cannot find namespace 'Protocol'. | ||
| lib/Page.js(432,7): error TS2740: Type '(...args: any[]) => Promise<any>' is missing the following properties from type 'Window': Blob, TextDecoder, TextEncoder, URL, and 231 more. | ||
| lib/Page.js(442,9): error TS2349: Cannot invoke an expression whose type lacks a call signature. Type 'Window' has no compatible call signatures. |
Member
There was a problem hiding this comment.
numeric index signature means that window[x] : Window where x: any. And the arrow in question is not assignable to Window.
| node_modules/chrome-devtools-frontend/front_end/Runtime.js(705,5): error TS2322: Type 'Promise<boolean>' is not assignable to type 'Promise<undefined>'. | ||
| node_modules/chrome-devtools-frontend/front_end/Runtime.js(715,7): error TS2322: Type 'Promise<void>' is not assignable to type 'Promise<undefined>'. | ||
| node_modules/chrome-devtools-frontend/front_end/Runtime.js(729,7): error TS2322: Type 'Promise<void>' is not assignable to type 'Promise<undefined>'. | ||
| node_modules/chrome-devtools-frontend/front_end/Runtime.js(746,5): error TS2322: Type 'Window | {}' is not assignable to type 'Window'. |
Member
There was a problem hiding this comment.
similar problem to puppeteer, except that the assignment almost works.
| node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(45,23): error TS2365: Operator '>=' cannot be applied to types 'RegExpMatchArray' and 'number'. | ||
| node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(47,76): error TS2365: Operator '<' cannot be applied to types 'RegExpMatchArray' and 'number'. | ||
| node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(94,25): error TS2339: Property 'createTextRange' does not exist on type 'HTMLElement'. | ||
| node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(94,25): error TS2339: Property 'createTextRange' does not exist on type 'HTMLBodyElement | HTMLFrameSetElement'. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh