Fix mixin logic to preserve at least one constructor type even when the intersection also contains non-constructor types. #27701
Conversation
|
@typescript-bot test this |
|
Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at a8b6164. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Willing to merge this if RWC is green or greenish |
|
@weswigham the RWC PR doesn't match this at all - definitely a bunch of unrelated changes. Can you investigate? |
|
@RyanCavanaugh you need to merge master into this PR - the RWC runner runs with the PR head, not the merge result |
intersection also contains non-constructor types. Fixes microsoft#17388.
mattmccutchen
force-pushed
the
issue-17388
branch
from
a8b6164 to
a724427
Compare
|
Updated to master. Please try the RWC again. |
|
@typescript-bot test this |
|
Heya @weswigham, I've started to run the extended test suite on this PR at a724427. You can monitor the build here. It should now contribute to this PR's status checks. |
|
@typescript-bot test this |
|
Heya @weswigham, I've started to run the extended test suite on this PR at d54833b. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Noice, RWC's clean, time to merge |
Fixes #17388.