Fix bug: Ensure JSDoc type range is valid #27343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ghost
requested a review
from 
sandersn
approved these changes
Oct 8, 2018
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Oct 24, 2018
mrcrane
pushed a commit
to mrcrane/TypeScript
that referenced
this pull request
Jul 26, 2019
…t#28008) * Fix bug: Ensure JSDoc type range is valid * Have scanJsDocToken scan keywords (microsoft#27162) * Have scanJsDocToken scan keywords * Update API * Add 'no-unnecessary-type-assertion' tslint disables
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash that occurred in updateTokenPositionsAndMarkElements when there was no type after
@typeas in/** @type */and the document was then edited. (Similar to #26283)This branch is based on #27162 and will be rebased after that is in.