Dont use unreliable inodes for checking file identity #25008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,26 +4,19 @@ const { join } = require("path"); | |||
|
|
|||
| /** | |||
| * Find the size of a directory recursively. | |||
| * Symbolic links are counted once (same inode). | |||
| * Symbolic links can cause a loop. | |||
RyanCavanaugh
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since node can report multiple files as having the same inode due to a casting bug, as just happened to me, ref nodejs/node#12115 (and we dont need to handle symlinks anyway, tbh).
Also concatenate with just
lf, since all the other line endings arelf, and we don't want mixed line endings in the lkg.