Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing signature for new Event. #2314

Closed
wants to merge 1 commit into from
Closed

Fixing signature for new Event. #2314

wants to merge 1 commit into from

Conversation

zimbabao
Copy link

new Event need two parameters, one medatory and one optional.
event = new Event(typeArg, eventInit);

Ref: https://developer.mozilla.org/en-US/docs/Web/API/Event/Event

@msftclas
Copy link

Hi @zimbabao, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@mhegazy
Copy link
Contributor

mhegazy commented Mar 12, 2015

Thanks @zimbabao for your PR. the files in bin folder are built at build time using jake LKG. the sources come from src\lib. now the problem is this definition is comes from another auto generated file form IE specifications. this makes it easy for us to get automatically updated DOM specifications without having some one manually add new APIs. we are in the process of rewriting this script, and will make it public so you can update the scrip. so if you can bare with us a few weeks we should have something out.

@mhegazy mhegazy closed this Mar 12, 2015
@rgaunker
Copy link

@mhegazy : Thanks for the reply.
Also how about not checking in autogenerated files and make it part of build process.

@mhegazy
Copy link
Contributor

mhegazy commented Mar 13, 2015

That is exactly the change we are making :)

@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants