Skip to content

remove GeneratorFunction global from lib.d.ts #21615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhegazy merged 1 commit into from
Feb 6, 2018
Merged

remove GeneratorFunction global from lib.d.ts #21615

mhegazy merged 1 commit into from
Feb 6, 2018

Conversation

@HerringtonDarkholme
Copy link
Contributor

@HerringtonDarkholme HerringtonDarkholme commented Feb 4, 2018

According to MDN:

Note that GeneratorFunction is not a global object.

I found the bug when reading #21527.

This code compiles in playground but throws a runtime error.

mhegazy
mhegazy approved these changes Feb 6, 2018
View reviewed changes
Copy link
Contributor

@mhegazy mhegazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rbuckton any concerns?

@mhegazy mhegazy merged commit abe814f into microsoft:master Feb 6, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Feb 6, 2018

thanks!

@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@rbuckton rbuckton rbuckton approved these changes

@mhegazy mhegazy mhegazy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HerringtonDarkholme @mhegazy @rbuckton