Simplify string literal completions #21415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating
CompletionInfo
directly, return a union of several kinds and convert toCompletionInfo
at the end. This is useful because we won't always want aCompletionInfo
(#21374). It also cuts down on code since we were duplicating the code to createCompletionInfo
in a lot of places.Note: Previously,
getStringLiteralCompletionEntriesFromCallExpression
returnedisNewIdentifierLocation: true
, butisNewIdentifierLocation: false
returnedisNewIdentifierLocation: false
. In both cases, we are getting the string literal from a contextual type, so I would expect these situations to work the same, and now we returnisNewIdentifierLocation: true
in both locations. Relevant testcompletionForStringLiteral3
which tests for this was added in #8428. @mhegazy