Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused type parameters should be checked by --noUnusedParameters, not --noUnusedLocals. #21167

Merged
merged 1 commit into from
Jan 26, 2018

Conversation

mattmccutchen
Copy link
Contributor

Fixes #20568.

Most of the existing test cases of unused type parameters passed both --noUnusedParameters and --noUnusedLocals. A few test cases passed only --noUnusedLocals and failed after I changed the code; I changed them to pass only --noUnusedParameters. I also added the two missing contexts of type parameters (method, lambda) to tests/cases/compiler/unusedTypeParametersWithUnderscore.ts and used this test case as the basis of new test cases testing specifically that unused type parameters are checked with --noUnusedParameters alone and not with --noUnusedLocals alone.

@mhegazy
Copy link
Contributor

mhegazy commented Jan 12, 2018

I am in the process of forking for TS 2.7, i will merge this once i am done.

@mhegazy mhegazy merged commit f0ba16c into microsoft:master Jan 26, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
@mattmccutchen mattmccutchen deleted the unused-type-parameter branch July 7, 2018 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants