Unused type parameters should be checked by --noUnusedParameters, not --noUnusedLocals. #21167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--noUnusedLocals. Fixes microsoft#20568.
mhegazy
approved these changes
Jan 12, 2018
|
I am in the process of forking for TS 2.7, i will merge this once i am done. |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20568.
Most of the existing test cases of unused type parameters passed both
--noUnusedParametersand--noUnusedLocals. A few test cases passed only--noUnusedLocalsand failed after I changed the code; I changed them to pass only--noUnusedParameters. I also added the two missing contexts of type parameters (method, lambda) totests/cases/compiler/unusedTypeParametersWithUnderscore.tsand used this test case as the basis of new test cases testing specifically that unused type parameters are checked with--noUnusedParametersalone and not with--noUnusedLocalsalone.