Skip to content

Fix build failure with newest @types/mocha #21075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhegazy merged 1 commit into from
Jan 8, 2018
Merged

Fix build failure with newest @types/mocha #21075

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/harness/parallel/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ namespace Harness.Parallel.Worker {
retries() { return this; },
slow() { return this; },
timeout(n) {
timeout = n;
timeout = n as number;
Copy link
Copy Markdown
Contributor

@mhegazy mhegazy Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be +n instead?

Copy link
Copy Markdown
Author

@ghost ghost Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on whether we believe it to be a number already, or believe that it actually could be a string and want to convert it to a number at runtime. @weswigham might know if the new type definition is actually accurate to our situation

return this;
},
};
Expand Down Expand Up @@ -127,7 +127,7 @@ namespace Harness.Parallel.Worker {
const fakeContext: Mocha.ITestCallbackContext = {
skip() { return this; },
timeout(n) {
timeout = n;
timeout = n as number;
return this;
},
retries() { return this; },
Expand Down