Include '@types/node' in ATA if commonjs modules are used #20844
Conversation
| @@ -3968,6 +3968,7 @@ namespace ts { | |||
| typeAcquisition: TypeAcquisition; // Used to customize the type acquisition process | |||
| compilerOptions: CompilerOptions; // Used as a source for typing inference | |||
| unresolvedImports: ReadonlyArray<string>; // List of unresolved module ids from imports | |||
| containsCommonJsRequire: boolean; // True if there is a `require()` call somewhere in the program | |||
There was a problem hiding this comment.
Should this be made optional? This interface is casted to in one place but I can't find anywhere we actually create it -- but it does happen to share a shape with interface DiscoverTypings in server.ts so maybe it comes from there?
|
I just realized that there's one place this could cause problems, which is in a |
|
@DanielRosenwasser What do those |
|
I do not think this the right fix. first it is a bit of a heavy hammer for the the other issue however is that does not handle the scenario listed in #21164, with the flashing of the error untill ATA gets to run. i think this may be different than the original problem here, but it may be related too.. let's talk about the approach we can take on Tuesday. |
|
Closing in favor of the proposal in #21933 |
ghost
deleted the
@DanielRosenwasser had recommended doing this.