-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #20026 #20157
Fixes #20026 #20157
Conversation
src/compiler/checker.ts
Outdated
@@ -15539,6 +15539,20 @@ namespace ts { | |||
return checkNonNullType(checkExpression(node), node); | |||
} | |||
|
|||
function checkNonNullCallLikeExpression(node: Expression | QualifiedName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i do not think we should duplicate the function implementation here. consider passing the new error messages as optional arguments to checkNullExpression instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhegazy thanks for the code review. I just sent a new commit that uses optional arguments instead of a new function.
Hi @mhegazy I just resolved some merge conflicts. Is there anything else that I can do to speed up merging this PR into master? Thanks! |
Sorry for the delay, can you please update your PR. |
@mhegazy thanks for merging the PR, can you please explain to me what was that timeout error in the build?
I would like to learn about it future contributions. Thanks! |
|
Here's a checklist you might find useful.
'Bug' or 'help wanted' or is in the Community milestone
master
branchjake runtests
locallyFixes #20026