Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #20026 #20157

Merged
merged 8 commits into from
Jan 9, 2018
Merged

Fixes #20026 #20157

merged 8 commits into from
Jan 9, 2018

Conversation

remojansen
Copy link
Contributor

@remojansen remojansen commented Nov 20, 2017

Here's a checklist you might find useful.

  • There is an associated issue that is labelled
    'Bug' or 'help wanted' or is in the Community milestone
  • Code is up-to-date with the master branch
  • You've successfully run jake runtests locally
  • You've signed the CLA
  • There are new or updated unit tests validating the change

Fixes #20026

@@ -15539,6 +15539,20 @@ namespace ts {
return checkNonNullType(checkExpression(node), node);
}

function checkNonNullCallLikeExpression(node: Expression | QualifiedName) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do not think we should duplicate the function implementation here. consider passing the new error messages as optional arguments to checkNullExpression instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhegazy thanks for the code review. I just sent a new commit that uses optional arguments instead of a new function.

@remojansen
Copy link
Contributor Author

remojansen commented Dec 6, 2017

Hi @mhegazy I just resolved some merge conflicts. Is there anything else that I can do to speed up merging this PR into master? Thanks!

@mhegazy
Copy link
Contributor

mhegazy commented Jan 8, 2018

Sorry for the delay, can you please update your PR.

@mhegazy mhegazy merged commit 73e3e8d into microsoft:master Jan 9, 2018
@remojansen
Copy link
Contributor Author

remojansen commented Jan 9, 2018

@mhegazy thanks for merging the PR, can you please explain to me what was that timeout error in the build?

src/harness/parallel/worker.ts:58:17 - error TS2322: Type 'string | number' is not assignable to type 'number'.
  Type 'string' is not assignable to type 'number'.

58                 timeout = n;
                   ~~~~~~~


src/harness/parallel/worker.ts:130:17 - error TS2322: Type 'string | number' is not assignable to type 'number'.
  Type 'string' is not assignable to type 'number'.

130                 timeout = n;
                    ~~~~~~~


jake aborted.
Error: ENOENT: no such file or directory, unlink 'built/local/run.js'
    at Object.fs.unlinkSync (fs.js:1061:18)
    at Exec.<anonymous> (/home/rjansen/CODE/TypeScript/Jakefile.js:417:16)

I would like to learn about it future contributions. Thanks!

@mhegazy
Copy link
Contributor

mhegazy commented Jan 9, 2018

@types/mocha changed, and we needed to respond to that. see #21075 for more details.

@remojansen remojansen deleted the issue-20026 branch January 9, 2018 18:00
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants