Care about esnext where we look for es2015#18331
Merged
weswigham merged 2 commits intoSep 9, 2017
Merged
Conversation
mhegazy
reviewed
Sep 7, 2017
| ==== tests/cases/conformance/externalModules/esnext/esnextmodulekindWithES5Target10.ts (3 errors) ==== | ||
| import i = require("mod"); // Error; | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| !!! error TS1202: Import assignment cannot be used when targeting ECMAScript 2015 modules. Consider using 'import * as ns from "mod"', 'import {a} from "mod"', 'import d from "mod"', or another module format instead. |
Contributor
There was a problem hiding this comment.
looks like the error message should be ECMAScript 2015 modules or later
Member
Author
There was a problem hiding this comment.
Just went with the more generic ECMAScript modules.
mhegazy
approved these changes
Sep 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds checks for
ModuleKind.ESNextwhere we check forModuleKind.ES2015, where appropriate.Fixes #17556.
For tests, I reused our some of our module kind es2015 tests (which I also moved, hence the path changes), but targeting
esnextinstead.