Handle the combination of a write and a void return#18164
Merged
Conversation
|
@amcasey, |
mhegazy
approved these changes
Sep 6, 2017
When the return type is void, there's no `returnValueProperty`, but that doesn't mean we don't need a `return` at the call site. Fixes microsoft#18140.
amcasey
added a commit
to amcasey/TypeScript
that referenced
this pull request
Sep 16, 2017
Handle the combination of a write and a void return (cherry picked from commit 02cfb81)
amcasey
added a commit
to amcasey/TypeScript
that referenced
this pull request
Sep 18, 2017
Handle the combination of a write and a void return (cherry picked from commit 02cfb81)
amcasey
added a commit
to amcasey/TypeScript
that referenced
this pull request
Sep 20, 2017
Handle the combination of a write and a void return (cherry picked from commit 02cfb81)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the return type is void, there's no
returnValueProperty, but thatdoesn't mean we don't need a
returnat the call site.Fixes #18140.