Use isPartOfExpression in extractMethod, not isExpression #18047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
rbuckton
approved these changes
Aug 25, 2017
Contributor
rbuckton
left a comment
rbuckton
left a comment
There was a problem hiding this comment.
Approved, pending minor comments.
| switch (node.kind) { | ||
| return isLeftHandSideExpressionKind(skipPartiallyEmittedExpressions(node).kind); | ||
| } | ||
| function isLeftHandSideExpressionKind(kind: SyntaxKind): boolean { |
| switch (node.kind) { | ||
| return isUnaryExpressionKind(skipPartiallyEmittedExpressions(node).kind); | ||
| } | ||
| function isUnaryExpressionKind(kind: SyntaxKind): boolean { |
| switch (node.kind) { | ||
| return isExpressionKind(skipPartiallyEmittedExpressions(node).kind); | ||
| } | ||
| function isExpressionKind(kind: SyntaxKind): boolean { |
This was referenced Aug 25, 2017
rbuckton
approved these changes
Aug 25, 2017
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the changes to
isExpressionfrom #18025. @rbuckton pointed out that we should be usingisPartOfExpressionoutside of transforms, notisExpression, sinceisExpressionshouldn't look atnode.parent.