Skip to content

Bind logger function before using #17983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhegazy merged 2 commits into from
Aug 23, 2017
Merged

Bind logger function before using #17983

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e247f31
Bind logger function before using
mhegazy Aug 23, 2017
9511afd
Use lambda isntead of bind
mhegazy Aug 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/server/typingsInstaller/typingsInstaller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ namespace ts.server.typingsInstaller {
}
const discoverTypingsResult = JsTyping.discoverTypings(
this.installTypingHost,
this.log.isEnabled() ? this.log.writeLine : undefined,
this.log.isEnabled() ? this.log.writeLine.bind(this.log) : undefined,

@weswigham weswigham Aug 23, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use line => this.log.writeLine(line) instead of .bind? AFAIK we'd avoided using bind in most places, why stop now?

@mhegazy mhegazy Aug 23, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we avoided bind.. why.

req.fileNames,
req.projectRootPath,
this.safeList,
Expand Down