Skip to content

quickInfo: Don't check for type === undefined, check for any#17815

Merged
2 commits merged into
masterfrom
quickInfoTypeError
Aug 19, 2017
Merged

quickInfo: Don't check for type === undefined, check for any#17815
2 commits merged into
masterfrom
quickInfoTypeError

Conversation

@ghost

@ghost ghost commented Aug 15, 2017

Copy link
Copy Markdown

Fixes #17683
getTypeAtLocation and getTypeOfSymbolAtLocation don't return undefined on failure, they return the any type.

Fixes:
a0b6d82 
* We still want to do some work even if type is `any`
* Second test for `if (type)` is necessary because it might not have been assigned.
@ghost ghost requested a review from weswigham August 18, 2017 19:48
@ghost ghost merged commit 5e8e735 into master Aug 19, 2017
@ghost ghost deleted the quickInfoTypeError branch August 19, 2017 00:21
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@weswigham @msftclas