Missing import codefix: Take scoped packages (@foo/bar) into consideration #17536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcasey
reviewed
Jul 31, 2017
| state = States.Scope; | ||
| } | ||
| else { | ||
| packageRootIndex = partEnd; |
There was a problem hiding this comment.
Another way to express this would be goto case States.PackageContent. That would have the benefit of emphasizing that the two states are the same except for the initial check in NodeModules.
There was a problem hiding this comment.
That's just what I was looking for thanks, I didn't know about that.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15223
When a package name has a scope, like
@angular/core, we weren't able to locate package.json correctly, only looking under the@angulardirectory. Which meant that we never read the 'main/`typingsproperty in package.json which would have helped us simplify the import module specifier.This fixes the parsing of the path so we can find package.json.