Document assignment to aliasSymbol in getUnionTypeFromSortedList #17434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
mentioned this pull request
sandersn
approved these changes
Aug 29, 2017
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
I suggested improved wording for one line.
src/compiler/checker.ts
Outdated
| type.types = types; | ||
| /* | ||
| Note: This is the alias symbol (or lack thereof) that we see when we first encounter this union type. | ||
| If there exist both `type T = number | boolean` and `type U = number | boolean`, it is arbitrary which one gets the aliasSymbol. |
Member
There was a problem hiding this comment.
I would write this line as
For aliases of identical unions, eg
type T = A | B; type U = A | B, the symbol of the first alias encountered is thealiasSymbol.
This is technically true even for the language server, but "first alias encountered" depends on the order of actions by the user.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #17349