Allow exporting const variables when strictNullChecks is on
#15330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcnew
commented
Apr 23, 2017
| ==== tests/cases/conformance/es6/modules/exportConsts.ts (2 errors) ==== | ||
| export { x } | ||
| export { x as xx } | ||
| export default x; |
There was a problem hiding this comment.
export default should still be an error, right?
There was a problem hiding this comment.
According to what I'm seeing in the spec, I believe that is correct. The declaration evaluates and may have a side-effect, whereas the others are simple bindings.
There was a problem hiding this comment.
Yes, that's what I understood as well. Thank you!
|
👍 |
sandersn
approved these changes
Apr 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15329