fix #14187, forIn should allow non primitive object as right hand side #14195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielRosenwasser
requested changes
Feb 21, 2017
| // assignable to right hand side of forIn | ||
| for (var key in a) { | ||
| var val = a[key] | ||
| } |
Member
There was a problem hiding this comment.
This test (conformance/types/nonPrimitive/assignObjectToNonPrimitive.ts) seems unrelated - would it be possible to remove this and create a new test? Something like conformance/types/nonPrimitive/indexingWithForInLoop01.ts seems more appropriate.
mhegazy
approved these changes
Feb 21, 2017
DanielRosenwasser
requested changes
Feb 21, 2017
| var a: object; | ||
|
|
||
| for (var key in a) { | ||
| var value = a[key]; // error |
Member
There was a problem hiding this comment.
But this isn't an error, right?
HerringtonDarkholme
force-pushed
the
object-iteration
branch
from
7d8889d to
5196607
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14187