Properly handle private and protected properties in intersections #13990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhegazy Want to review this before I merge? |
mhegazy
approved these changes
Feb 13, 2017
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we properly handle
privateandprotectedproperties in intersection types. This fixes several issues related to use ofprivateandprotectedin mixins (which use intersections to construct the resulting types).This PR also introduces a new
CheckFlagsenum type representing bit flags that are present in everyTransientSymbol(i.e. every symbol created by the type checker) and moves theInstantiatedandSyntheticPropertyflags fromSymbolFlagsto the newCheckFlags. Furthermore, theMergedflag is removed fromSymbolFlagssince theTransientflag already provides the same information.Fixes #13830.
Fixes #13924.