Fix #13932: Change the order of overloads and allow union for Object.create
#13936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfaproject
reviewed
Feb 7, 2017
|
|
||
| declare var union: null | { a: number, b: string }; | ||
|
|
||
| var n = Object.create(null); // object |
There was a problem hiding this comment.
Isn't this a 'well defined' object, namely {}?
Contributor
Author
There was a problem hiding this comment.
in an input {} is not the same as object. object is more specific than {}. in here it does not matter. i used object to avoid having a type of {} | object.
sandersn
approved these changes
Feb 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nulllast. this allows the error to show even in non-strict null checks modeobject | nullto address Object.create({} | null) #13932, and make sure the result is the union of the input, e.g.Object.create(T | null)isT | object.//CC @RyanCavanaugh and @DanielRosenwasser
Fixes #13932