Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transforms] Decorator meta data property names, and shape have changed #7878

Closed
mhegazy opened this issue Apr 6, 2016 · 1 comment
Closed
Assignees
Labels
Bug A bug in TypeScript Domain: Transforms Relates to the public transform API Fixed A PR has been merged for this issue

Comments

@mhegazy
Copy link
Contributor

mhegazy commented Apr 6, 2016

As discussed offline, we should limit the breaking change for this iteration, and include these changes later on.

Expected:

MyClass = __decorate([
    someDecorator, 
    __metadata('design:paramtypes', [db_1.default])
], MyClass);
exports.MyClass = MyClass;

Actual:

MyClass = __decorate([
    someDecorator,
    __metadata("design:typeinfo", {
        paramTypes: function () { return [db_1.default]; }
    })
], MyClass);

Failed tests:

  • tests\cases\compiler\decoratorMetadataWithImportDeclarationNameCollision6.ts
@mhegazy mhegazy added Bug A bug in TypeScript Domain: Transforms Relates to the public transform API labels Apr 6, 2016
rbuckton added a commit that referenced this issue Apr 7, 2016
@rbuckton
Copy link
Member

rbuckton commented Apr 7, 2016

Fixed in #7919.

@rbuckton rbuckton closed this as completed Apr 7, 2016
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Apr 14, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Domain: Transforms Relates to the public transform API Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

2 participants