-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable TS Server plugins on web #47376
Comments
At the moment VS Code doesn't even try to initialize plugins with the server. However once I remove this check on the VS Code side, the code starts failing at TypeScript/src/webServer/webServer.ts Line 139 in c0796c1
|
I wonder if we need a browser version of these plugins too, similar to what VS Code does for extensions in browsers
|
This is a first exploration for microsoft#47376 microsoft/vscode#140455 It implements a very basic version of `require` for the web that lets us load plugins with a very specific structure. `require` being sync limits our options here, so I'm using `importScripts` plus a global to get the exports of a plugin. The plugin must also be compiled down to a single file at the moment
I've cleaned up my prototype in #47377 quite a bit. Noteworthy changes:
I think web enabled plugins are good opportunity to move plugins to adopt modern JS practices. Trying to load plugins synchronously on web is also very ugly as my original prototype showed |
Thanks all for the help. @rbuckton Since this change is already merged, do you have any idea when would this be available? |
PRs merged today will be in the nightly build starting immediately the following day, and also in 4.8 Beta (plus any subsequent release) |
For microsoft/vscode#140455
A few key VS Code extensions — such as IntelliCode — are powered by TS Server plugins. Currently we don't support loading these plugins at all on web versions of TypeScript
This feature request tracks enabling plugins from extensions on vscode.dev and GitHub.dev. We don't plan to support plugins from the workspace since these require running npm install
The text was updated successfully, but these errors were encountered: