Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getRegistration in ServiceWorkerContainer's optional parameter is missing from 2.6.1 #20065

Closed
cheung-chifung opened this issue Nov 16, 2017 · 2 comments · Fixed by #20177
Closed

getRegistration in ServiceWorkerContainer's optional parameter is missing from 2.6.1 #20065

cheung-chifung opened this issue Nov 16, 2017 · 2 comments · Fixed by #20177
Assignees
@mhegazy
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Milestone
TypeScript 2.7

Comments

@cheung-chifung
Copy link

In 2.5.2, getRegistration has an optional parameter clientURL?: USVString, which is missing from 2.6.1.

According to MDN, this parameter is optional.

https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerContainer/getRegistration

Maybe a coding miss in this diff: https://github.com/Microsoft/TypeScript/pull/18774/files#diff-46fd87925e4552c166ec188712741c3fL9534

TypeScript Version: 2.6.1

Code

Expected behavior:

clientURL should be acceptable.

Actual behavior:
@mhegazy mhegazy added Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this labels Nov 16, 2017
@mhegazy mhegazy added this to the Community milestone Nov 16, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Nov 16, 2017

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

@cheung-chifung cheung-chifung changed the title getRegistration in ServiceWorkerContainer's optional is missing from 2.6.1 getRegistration in ServiceWorkerContainer's optional parameter is missing from 2.6.1 Nov 18, 2017
cheung-chifung added a commit to cheung-chifung/TSJS-lib-generator that referenced this issue Nov 18, 2017
@cheung-chifung
Fix getRegistration's parameter
ee97ac2 
Issue: microsoft/TypeScript#20065
cheung-chifung added a commit to cheung-chifung/TSJS-lib-generator that referenced this issue Nov 18, 2017
@cheung-chifung
Fix getRegistration's parameter
473fcb5 
Issue: microsoft/TypeScript#20065
@cheung-chifung cheung-chifung mentioned this issue Nov 18, 2017
Merged
@cheung-chifung
Copy link
Author

I fixed it in Microsoft/TSJS-lib-generator.
Please check: microsoft/TypeScript-DOM-lib-generator#323

@mhegazy mhegazy added the Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet label Nov 20, 2017
@mhegazy mhegazy modified the milestones: Community, TypeScript 2.7 Nov 20, 2017
@mhegazy mhegazy self-assigned this Nov 20, 2017
@mhegazy mhegazy mentioned this issue Nov 21, 2017
Merged
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Nov 21, 2017
@mhegazy mhegazy removed the Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet label Nov 21, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mhegazy mhegazy

Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Milestone
TypeScript 2.7
Development

Successfully merging a pull request may close this issue.

Port generated lib files microsoft/TypeScript
2 participants
@cheung-chifung @mhegazy