Fix undefined error using getEffectiveTypeRoots (#19300)

microsoft · Oct 18, 2017 · f1abe3c · f1abe3c
1 parent e5f8287
commit f1abe3c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/harness/harnessLanguageService.ts b/src/harness/harnessLanguageService.ts
@@ -212,6 +212,11 @@ namespace Harness.LanguageService {
             return script ? script.version.toString() : undefined;
         }
 
+        directoryExists(dirName: string): boolean {
+            const fileEntry = this.virtualFileSystem.traversePath(dirName);
+            return fileEntry && fileEntry.isDirectory();
+        }
+
         fileExists(fileName: string): boolean {
             const script = this.getScriptSnapshot(fileName);
             return script !== undefined;

diff --git a/src/services/codefixes/importFixes.ts b/src/services/codefixes/importFixes.ts
@@ -367,7 +367,8 @@ namespace ts.codefix {
         getCanonicalFileName: (file: string) => string,
         moduleFileName: string,
     ): string | undefined {
-        return firstDefined(getEffectiveTypeRoots(options, host), unNormalizedTypeRoot => {
+        const roots = getEffectiveTypeRoots(options, host);
+        return roots && firstDefined(roots, unNormalizedTypeRoot => {
             const typeRoot = toPath(unNormalizedTypeRoot, /*basePath*/ undefined, getCanonicalFileName);
             if (startsWith(moduleFileName, typeRoot)) {
                 return removeExtensionAndIndexPostFix(moduleFileName.substring(typeRoot.length + 1));