Fixed JS completions type spread (#45484)

* Fix and updated tests * Added test * Revert "Fix and updated tests" This reverts commit 33829fa. * Filter out empty access expression * PR feedback
microsoft · Aug 24, 2021 · ead9dfb · ead9dfb
1 parent b45e129
commit ead9dfb
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 4 deletions.
diff --git a/src/services/completions.ts b/src/services/completions.ts
@@ -1338,13 +1338,16 @@ namespace ts.Completions {
                     case SyntaxKind.PropertyAccessExpression:
                         propertyAccessToConvert = parent as PropertyAccessExpression;
                         node = propertyAccessToConvert.expression;
-                        if ((isCallExpression(node) || isFunctionLike(node)) &&
-                            node.end === contextToken.pos &&
-                            node.getChildCount(sourceFile) &&
-                            last(node.getChildren(sourceFile)).kind !== SyntaxKind.CloseParenToken) {
+                        const leftmostAccessExpression = getLeftmostAccessExpression(propertyAccessToConvert);
+                        if (nodeIsMissing(leftmostAccessExpression) ||
+                            ((isCallExpression(node) || isFunctionLike(node)) &&
+                                node.end === contextToken.pos &&
+                                node.getChildCount(sourceFile) &&
+                                last(node.getChildren(sourceFile)).kind !== SyntaxKind.CloseParenToken)) {
                             // This is likely dot from incorrectly parsed expression and user is starting to write spread
                             // eg: Math.min(./**/)
                             // const x = function (./**/) {}
+                            // ({./**/})
                             return undefined;
                         }
                         break;

diff --git a/tests/cases/fourslash/getJavaScriptCompletions22.ts b/tests/cases/fourslash/getJavaScriptCompletions22.ts
@@ -0,0 +1,12 @@
+/// <reference path="fourslash.ts" />
+
+// Regresion test for GH#45436
+
+// @allowNonTsExtensions: true
+// @Filename: file.js
+//// const abc = {};
+//// ({./*1*/});
+
+goTo.marker('1');
+edit.insert('.');
+verify.completions({ exact: undefined });