make sortText lower priority for snippets

microsoft · Mar 9, 2022 · 814561f · 814561f
1 parent 6c96290
commit 814561f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/src/services/completions.ts b/src/services/completions.ts
@@ -793,6 +793,7 @@ namespace ts.Completions {
             }
             ({ insertText, isSnippet, importAdder, sourceDisplay } = entry);
             source = CompletionSource.ObjectLiteralMethodSnippet;
+            sortText = (parseInt(sortText, 10) + 1).toString() as SortText;
             if (importAdder.hasFixes()) {
                 hasAction = true;
             }

diff --git a/tests/cases/fourslash/completionsObjectLiteralMethod1.ts b/tests/cases/fourslash/completionsObjectLiteralMethod1.ts
@@ -47,7 +47,7 @@ verify.completions({
         },
         {
             name: "bar",
-            sortText: completion.SortText.LocationPriority,
+            sortText: completion.SortText.OptionalMember,
             source: completion.CompletionSource.ObjectLiteralMethodSnippet,
             insertText: "bar(x: number): void {\n},",
         },
@@ -68,7 +68,7 @@ verify.completions({
         },
         {
             name: "bar",
-            sortText: completion.SortText.LocationPriority,
+            sortText: completion.SortText.OptionalMember,
             source: completion.CompletionSource.ObjectLiteralMethodSnippet,
             insertText: "bar(x: number): void {\n},",
         },
@@ -79,7 +79,7 @@ verify.completions({
         },
         {
             name: "foo",
-            sortText: completion.SortText.LocationPriority,
+            sortText: completion.SortText.OptionalMember,
             source: completion.CompletionSource.ObjectLiteralMethodSnippet,
             insertText: "foo(x: string): string {\n},",
         },
@@ -116,7 +116,7 @@ verify.completions({
         },
         {
             name: "\"space bar\"",
-            sortText: completion.SortText.LocationPriority,
+            sortText: completion.SortText.OptionalMember,
             source: completion.CompletionSource.ObjectLiteralMethodSnippet,
             insertText: "\"space bar\"(): string {\n},",
         },
@@ -137,7 +137,7 @@ verify.completions({
         },
         {
             name: "bar",
-            sortText: completion.SortText.LocationPriority,
+            sortText: completion.SortText.OptionalMember,
             source: completion.CompletionSource.ObjectLiteralMethodSnippet,
             isSnippet: true,
             insertText: "bar(x: number): void {\n    $0\n},",

diff --git a/tests/cases/fourslash/completionsObjectLiteralMethod2.ts b/tests/cases/fourslash/completionsObjectLiteralMethod2.ts
@@ -33,7 +33,7 @@ verify.completions({
         },
         {
             name: "foo",
-            sortText: completion.SortText.LocationPriority,
+            sortText: completion.SortText.OptionalMember,
             source: completion.CompletionSource.ObjectLiteralMethodSnippet,
             insertText: "foo(f: IFoo): void {\n},",
             hasAction: true,