Fix Get/Set being enumerable (#32264)

* Fix Get/Set being enumerable fixes #3610 * fix tests Co-authored-by: Nathan Shively-Sanders <[email protected]>
microsoft · Feb 27, 2020 · 5c85feb · 5c85feb
1 parent e7c578a
commit 5c85feb
Show file tree

Hide file tree

Showing 296 changed files with 1,541 additions and 1,317 deletions.
diff --git a/src/compiler/factory.ts b/src/compiler/factory.ts
@@ -566,7 +566,7 @@ namespace ts {
                 properties.push(setter);
             }
 
-            properties.push(createPropertyAssignment("enumerable", createTrue()));
+            properties.push(createPropertyAssignment("enumerable", getAccessor || setAccessor ? createFalse() : createTrue()));
             properties.push(createPropertyAssignment("configurable", createTrue()));
 
             const expression = setTextRange(

diff --git a/src/compiler/transformers/es2015.ts b/src/compiler/transformers/es2015.ts
@@ -1675,7 +1675,7 @@ namespace ts {
             }
 
             properties.push(
-                createPropertyAssignment("enumerable", createTrue()),
+                createPropertyAssignment("enumerable", getAccessor || setAccessor ? createFalse() : createTrue()),
                 createPropertyAssignment("configurable", createTrue())
             );
 

diff --git a/tests/baselines/reference/MemberAccessorDeclaration15.js b/tests/baselines/reference/MemberAccessorDeclaration15.js
@@ -9,7 +9,7 @@ var C = /** @class */ (function () {
     }
     Object.defineProperty(C.prototype, "Foo", {
         set: function (a) { },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return C;

diff --git a/tests/baselines/reference/abstractProperty.js b/tests/baselines/reference/abstractProperty.js
@@ -51,7 +51,7 @@ var C = /** @class */ (function (_super) {
     Object.defineProperty(C.prototype, "prop", {
         get: function () { return "foo"; },
         set: function (v) { },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     C.prototype.m = function () { };

diff --git a/tests/baselines/reference/abstractPropertyNegative.js b/tests/baselines/reference/abstractPropertyNegative.js
@@ -71,7 +71,7 @@ var C = /** @class */ (function (_super) {
     }
     Object.defineProperty(C.prototype, "concreteWithNoBody", {
         get: function () { },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return C;
@@ -104,7 +104,7 @@ var WrongTypeAccessorImpl = /** @class */ (function (_super) {
     }
     Object.defineProperty(WrongTypeAccessorImpl.prototype, "num", {
         get: function () { return "nope, wrong"; },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return WrongTypeAccessorImpl;
@@ -123,13 +123,13 @@ var AbstractAccessorMismatch = /** @class */ (function () {
     }
     Object.defineProperty(AbstractAccessorMismatch.prototype, "p1", {
         set: function (val) { },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     ;
     Object.defineProperty(AbstractAccessorMismatch.prototype, "p2", {
         get: function () { return "should work"; },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return AbstractAccessorMismatch;

diff --git a/tests/baselines/reference/accessibilityModifiers.js b/tests/baselines/reference/accessibilityModifiers.js
@@ -52,34 +52,34 @@ var C = /** @class */ (function () {
     C.privateMethod = function () { };
     Object.defineProperty(C, "privateGetter", {
         get: function () { return 0; },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     Object.defineProperty(C, "privateSetter", {
         set: function (a) { },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     C.protectedMethod = function () { };
     Object.defineProperty(C, "protectedGetter", {
         get: function () { return 0; },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     Object.defineProperty(C, "protectedSetter", {
         set: function (a) { },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     C.publicMethod = function () { };
     Object.defineProperty(C, "publicGetter", {
         get: function () { return 0; },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     Object.defineProperty(C, "publicSetter", {
         set: function (a) { },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return C;
@@ -91,34 +91,34 @@ var D = /** @class */ (function () {
     D.privateMethod = function () { };
     Object.defineProperty(D, "privateGetter", {
         get: function () { return 0; },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     Object.defineProperty(D, "privateSetter", {
         set: function (a) { },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     D.protectedMethod = function () { };
     Object.defineProperty(D, "protectedGetter", {
         get: function () { return 0; },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     Object.defineProperty(D, "protectedSetter", {
         set: function (a) { },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     D.publicMethod = function () { };
     Object.defineProperty(D, "publicGetter", {
         get: function () { return 0; },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     Object.defineProperty(D, "publicSetter", {
         set: function (a) { },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return D;
@@ -130,12 +130,12 @@ var E = /** @class */ (function () {
     E.prototype.method = function () { };
     Object.defineProperty(E.prototype, "getter", {
         get: function () { return 0; },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     Object.defineProperty(E.prototype, "setter", {
         set: function (a) { },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return E;

diff --git a/tests/baselines/reference/accessorParameterAccessibilityModifier.js b/tests/baselines/reference/accessorParameterAccessibilityModifier.js
@@ -10,12 +10,12 @@ var C = /** @class */ (function () {
     }
     Object.defineProperty(C.prototype, "X", {
         set: function (v) { },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     Object.defineProperty(C, "X", {
         set: function (v2) { },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return C;

diff --git a/tests/baselines/reference/accessorWithES3.js b/tests/baselines/reference/accessorWithES3.js
@@ -29,7 +29,7 @@ var C = /** @class */ (function () {
         get: function () {
             return 1;
         },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return C;
@@ -40,7 +40,7 @@ var D = /** @class */ (function () {
     Object.defineProperty(D.prototype, "x", {
         set: function (v) {
         },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return D;

diff --git a/tests/baselines/reference/accessorWithES5.js b/tests/baselines/reference/accessorWithES5.js
@@ -26,7 +26,7 @@ var C = /** @class */ (function () {
         get: function () {
             return 1;
         },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return C;
@@ -37,7 +37,7 @@ var D = /** @class */ (function () {
     Object.defineProperty(D.prototype, "x", {
         set: function (v) {
         },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return D;

diff --git a/tests/baselines/reference/accessorWithInitializer.js b/tests/baselines/reference/accessorWithInitializer.js
@@ -12,14 +12,14 @@ var C = /** @class */ (function () {
         set: function (v) {
             if (v === void 0) { v = 0; }
         },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     Object.defineProperty(C, "X", {
         set: function (v2) {
             if (v2 === void 0) { v2 = 0; }
         },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return C;

diff --git a/tests/baselines/reference/accessorWithLineTerminator.js b/tests/baselines/reference/accessorWithLineTerminator.js
@@ -14,7 +14,7 @@ var C = /** @class */ (function () {
     Object.defineProperty(C.prototype, "x", {
         get: function () { return 1; },
         set: function (v) { },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return C;

diff --git a/tests/baselines/reference/accessorWithMismatchedAccessibilityModifiers.js b/tests/baselines/reference/accessorWithMismatchedAccessibilityModifiers.js
@@ -41,7 +41,7 @@ var C = /** @class */ (function () {
         },
         set: function (v) {
         },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return C;
@@ -55,7 +55,7 @@ var D = /** @class */ (function () {
         },
         set: function (v) {
         },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return D;
@@ -69,7 +69,7 @@ var E = /** @class */ (function () {
         },
         set: function (v) {
         },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return E;
@@ -83,7 +83,7 @@ var F = /** @class */ (function () {
         },
         set: function (v) {
         },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return F;

diff --git a/tests/baselines/reference/accessorWithRestParam.js b/tests/baselines/reference/accessorWithRestParam.js
@@ -15,7 +15,7 @@ var C = /** @class */ (function () {
                 v[_i] = arguments[_i];
             }
         },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     Object.defineProperty(C, "X", {
@@ -25,7 +25,7 @@ var C = /** @class */ (function () {
                 v2[_i] = arguments[_i];
             }
         },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return C;

diff --git a/tests/baselines/reference/accessorsAreNotContextuallyTyped.js b/tests/baselines/reference/accessorsAreNotContextuallyTyped.js
@@ -24,7 +24,7 @@ var C = /** @class */ (function () {
         },
         set: function (v) {
         },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return C;

diff --git a/tests/baselines/reference/accessorsEmit.js b/tests/baselines/reference/accessorsEmit.js
@@ -29,7 +29,7 @@ var Test = /** @class */ (function () {
             var x = 1;
             return null;
         },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return Test;
@@ -42,7 +42,7 @@ var Test2 = /** @class */ (function () {
             var x = 1;
             return null;
         },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return Test2;

diff --git a/tests/baselines/reference/accessorsNotAllowedInES3.js b/tests/baselines/reference/accessorsNotAllowedInES3.js
@@ -11,7 +11,7 @@ var C = /** @class */ (function () {
     }
     Object.defineProperty(C.prototype, "x", {
         get: function () { return 1; },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return C;

diff --git a/tests/baselines/reference/accessorsOverrideProperty7.js b/tests/baselines/reference/accessorsOverrideProperty7.js
@@ -40,7 +40,7 @@ var B = /** @class */ (function (_super) {
     Object.defineProperty(B.prototype, "p", {
         get: function () { return 'oh no'; } // error
         ,
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return B;

diff --git a/tests/baselines/reference/accessors_spec_section-4.5_error-cases.js b/tests/baselines/reference/accessors_spec_section-4.5_error-cases.js
@@ -20,25 +20,25 @@ var LanguageSpec_section_4_5_error_cases = /** @class */ (function () {
     Object.defineProperty(LanguageSpec_section_4_5_error_cases.prototype, "AnnotatedSetter_SetterFirst", {
         get: function () { return ""; },
         set: function (a) { },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     Object.defineProperty(LanguageSpec_section_4_5_error_cases.prototype, "AnnotatedSetter_SetterLast", {
         get: function () { return ""; },
         set: function (a) { },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     Object.defineProperty(LanguageSpec_section_4_5_error_cases.prototype, "AnnotatedGetter_GetterFirst", {
         get: function () { return ""; },
         set: function (aStr) { aStr = 0; },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     Object.defineProperty(LanguageSpec_section_4_5_error_cases.prototype, "AnnotatedGetter_GetterLast", {
         get: function () { return ""; },
         set: function (aStr) { aStr = 0; },
-        enumerable: true,
+        enumerable: false,
         configurable: true
     });
     return LanguageSpec_section_4_5_error_cases;